feat: add token_pattern parameter to EntryPredictor#154
Merged
tarioch merged 4 commits intobeancount:mainfrom Feb 11, 2026
Merged
feat: add token_pattern parameter to EntryPredictor#154tarioch merged 4 commits intobeancount:mainfrom
tarioch merged 4 commits intobeancount:mainfrom
Conversation
Collaborator
|
thanks for your contribution, would you mind having a look at the failing tests? |
Contributor
Author
it's a lint failed at |
Collaborator
|
Yeah, I think in this case suppressing it makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a unavoidable warning when you replace the tokenizer, for example,
tokenizer=jieba.cut, we also expose token_pattern so user can override it.venv/Lib/site-packages/sklearn/feature_extraction/text.py:526: UserWarning: The parameter 'token_pattern' will not be used since 'tokenizer' is not None'