deps: drop py3.8, support py3.9+#217
Merged
wesselb merged 2 commits intobeartype:masterfrom Oct 3, 2025
Merged
Conversation
nstarman
force-pushed
the
mnt/py38
branch
4 times, most recently
from
7f50a0d to
b533e09
Compare
Collaborator
Author
|
@wesselb this PR is ready for review :) |
Pull Request Test Coverage Report for Build 18171967968Details
💛 - Coveralls |
Collaborator
Author
|
2nd commit simplifies a lot of imports! |
wesselb
reviewed
Oct 1, 2025
Member
There was a problem hiding this comment.
Yes, this is great! Thanks, @nstarman. :) It's about time Plum drops support for 3.8. I've left two comments.
Would it perhaps also be possible to replace e.g. typing.List by list in the code blocks in the docs? This is a bit annoying, so I can also do this myself.
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's very old and even new versions of pip don't support it.