Mapping improvements and cleanup #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stripped trailing spaces - Replaced mixed indentation styles with one
- Use consistent command abbreviations - Use ! with normal where appropriate - Use nore- mappings where appropriate - Other misc. formatting
- Only set buffer-local mappings - Use <LocalLeader> rather than hardcoding "\" - Use script-local functions with <Plug> maps - Only set default maps if none already exist
Users likely already have an ftplugin/php.vim file
- Ensure property is placed in containing class, not next class - Do not assume opening bracket is on next line
|
@beberlei, is there any reason why you don't want to merge this PR? |
|
Why using nmap instead of nnoremap? Also for "extractMethod" this should be used. Regards, |
Look again at the righthand side of the expression. Those —N |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made a few adjustments to your plug-in involving, most importantly, making the maps configurable. See commit messages for the specifics. I'm opening this pull request to share if interested, but feel free to ignore.
I'll likely be making more changes later such as restoring registers within functions and using getpos()/setpos() instead of marks.