Allow prefix behavior to depend on the field's type #4684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I helped add the exact match query feature last year, but the exact-match prefix
=
does not seem to work forPathQuery
. After stepping through this code for a while tonight, I believe this becauseMatchQuery
does not know to convert its pattern to amemoryview
.The proposed solution here tweaks the way prefixes work, allowing any prefix string to be assigned to a dictionary mapping the field's un-prefixed query type to the prefix's desired query type (use a defaultdict to provide a default query class, if desired).
I thought this made sense (vs simply checking for the field name 'path') to support plugins that may want to use this functionality for their own ends. But is there a better, more straightforward approach that I could have used?
(...)
To Do
docs/
to describe it.)docs/changelog.rst
near the top of the document.)