-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extension issue in convert plugin when exporting a playlist #5203
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the PR. I've left a comment or two. Would you also be able to add a test that fails under the old code and succeeds with the new?
I'm not familiar with unit tests in Python, but since you ask, I will give a try! |
Before this, the exported playlist contained relative paths pointing to the converted files BUT the extension were not substituted comparing to before and the after the conversion. Therefore, running the playlist will fail for files which have been converted and where extension have changed.
This reverts commit 52b639b.
de258e8
to
02c8fc3
Compare
I added the appropriate test case! ;) |
Hello, kind reminder, is there anything that I can do on my side to see this PR being merged? :) @Serene-Arc |
Fix linting error Ruff (PT009)
Description
Fix extension substitution inside path of the exported playlist.
Before this, the exported playlist contained relative paths pointing to the
converted files BUT the extension were not substituted comparing to before and
the after the conversion. Therefore, running the playlist will fail for files
which have been converted and where extension have changed.
Example:
/path/to/library/artist.flac
to/path/to/converted/artist.mp3
using the-m playlist.m3u
command-line flag./path/to/converted/artist.flac
inside.To Do