Lyrics: Resurrect translations and refactor ReST and command line handling #5485
+521
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
force-pushed
the
lyrics-translations
branch
3 times, most recently
from
5ec1cf8 to
99de0b1
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
cb559f0 to
95c954a
Compare
snejus
force-pushed
the
lyrics-translations
branch
2 times, most recently
from
abc5aef to
55a79ec
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
95c954a to
ebf136f
Compare
snejus
force-pushed
the
lyrics-translations
branch
from
55a79ec to
2c4406b
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
ebf136f to
09c0b9f
Compare
snejus
force-pushed
the
lyrics-translations
branch
from
2c4406b to
13034c9
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
09c0b9f to
83c125c
Compare
snejus
force-pushed
the
lyrics-translations
branch
2 times, most recently
from
952ba1e to
1bf3e9f
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
83c125c to
4531297
Compare
snejus
force-pushed
the
lyrics-translations
branch
2 times, most recently
from
035bee1 to
b792a84
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
2 times, most recently
from
2f068c4 to
112ddf9
Compare
snejus
force-pushed
the
lyrics-translations
branch
2 times, most recently
from
de0e0b5 to
e2b5078
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
112ddf9 to
fcd4d2b
Compare
snejus
force-pushed
the
lyrics-translations
branch
from
e2b5078 to
bc78084
Compare
snejus
force-pushed
the
lyrics-general-improvements
branch
from
fcd4d2b to
23b7417
Compare
I found that the translator would sometimes replace the pipe character with another symbol (maybe it got confused thinking the character is part of the text?). Added spaces around the pipe to make it more clear that it's definitely the separator.
snejus
force-pushed
the
lyrics-general-improvements
branch
from
23b7417 to
80d1c9f
Compare
snejus
force-pushed
the
lyrics-translations
branch
from
bc78084 to
80a9a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎵 The Refactoring Blues 🎵 by Claude
Verse 1:
Got those lyrics plugin blues
Cleaning up some messy code
Moving classes, fixing views
Making changes down the road
Chorus:
We're refactoring tonight
Making the codebase clean and bright
Translation's got a brand new home
And ReST files found their own
Verse 2:
Added Microsoft Translate
Keeping tokens safe and sound
Config options up-to-date
Better structure all around
Bridge:
Path operations simplified
Groups of artists, neat and tied
Error handling's looking fine
Comments clear along each line
Verse 3:
RestFiles in their own class now
Cleaning imports, showing how
Better typing makes it clear
What should go and what stays here
Final Chorus:
We're refactoring tonight
Making the codebase clean and bright
Translation's got a brand new home
And our code can stand alone!
— inspired by the diff
Technical Changes
Replaced deprecated and broken Bing translations by Microsoft Translator API
Translatorclass.Created RestFiles class for ReST document handling
Improved command line options handling
Caching of translations
The plugin will not re-translate lyrics if translations already exist, see