Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple params in url and added method to obtain query string as dictionary #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support for multiple params in url and added method to obtain query string as dictionary #51

wants to merge 5 commits into from

Conversation

Beormund
Copy link

@Beormund Beormund commented Nov 16, 2022 •
edited
Loading

Adds ability to specify multiple parameter names

@app.resource('/cmnd/<device>/<state>')
def cmndstate(data, device, state):
    return {'device':  device, 'state':  state}

Adds ability to obtain query string as a dictionary from request object.

@app.route('/cmnd')
async def cmnd(request, response):
    d = request.read_parse_query_data()
    await response.start_html()
    await response.send(f"<html><body><h1>{d}</h1></body></html>")

@Beormund
Update server.py
e832fbb 
Adds ability to specify multiple parameter names in restful urls.

Adds ability to obtain query string as a dictionary from request object.
@Beormund
Fix greedy path matching bug in _find_url_handler
8651dbf 
Fix greedy matching of url root. Now _find_url_handler has to match path and params for parameterized urls.
@Beormund
Copy link
Author

It looks like we could get away with storing just the parameter count in params['_param_names']. I can't see the param names being used anywhere else. Perhaps change this to params['_param_count']. It could then be used to pass the correct number of arguments to the user's route function.

@Beormund
Changed param names to param count
e78ca97 
Changed params['_param_names'] to params['_param_count']. Also made further improvements to path/param detection in _find_url_handler.
@Beormund
Method read_parse_query_data modified
def4d26 
No need for this helper method to be async.
@Beormund
Bug fix non-existent asyncio.cancel
4df3f45 
Replaced asyncio.cancel calls with task.cancel and removed unused processed_connections count. Also, self.conns[hid] = handler is now self.conns[hid] = task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Beormund