Merged
Conversation
The deleted_at field is used by ElectionActiveManager to filter out soft-deleted elections on every query (deleted_at__isnull=True). Adding an index improves query performance.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a database index on the deleted_at column of the Election model to improve query performance. The deleted_at field is used by the custom ElectionManager to filter out soft-deleted elections in every query using deleted_at__isnull=True.
Changes:
- Added
db_index=Trueparameter to thedeleted_atfield in the Election model - Created migration 0009 to add the database index to the existing field
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helios/models.py | Added db_index=True to the deleted_at field definition |
| helios/migrations/0009_add_deleted_at_index.py | Created migration to add index on deleted_at column |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted_at field is used by ElectionActiveManager to filter out soft-deleted elections on every query (deleted_at__isnull=True). Adding an index improves query performance.