Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double parentheses when returning JSXElements using Babel parser #1406

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tim-dev
Copy link

@tim-dev tim-dev commented Jun 17, 2024

Doing a print on a JSXElement that was parenthesized in Babel (noted via extra.parenthesized) was causing a double parentheses situation to happen, like:

return (
   (<Button>
   Text
   </Button>)
)

@tim-dev tim-dev force-pushed the 2024/06/fix_double_parentheses branch from 6889ab7 to 91896cf Compare June 18, 2024 05:40
@tim-dev tim-dev changed the title fix double parentheses when returning JSXElements fix double parentheses when returning JSXElements using Babel parser Jun 18, 2024
@tim-dev tim-dev changed the title fix double parentheses when returning JSXElements using Babel parser fix: double parentheses when returning JSXElements using Babel parser Jun 18, 2024
@danieldelcore
Copy link

@eventualbuddha @benjamn If you have time, I'd really appreciate your eyes on this one 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants