Remove remove_BE_USE_PRECOMPILED_OBJECT, always on#522
Open
s-hadinger wants to merge 1 commit intoberry-lang:masterfrom
Open
Remove remove_BE_USE_PRECOMPILED_OBJECT, always on#522s-hadinger wants to merge 1 commit intoberry-lang:masterfrom
s-hadinger wants to merge 1 commit intoberry-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to simplify source code, I suggest to remove the
BE_USE_PRECOMPILED_OBJECToption and to enforce it always. I believe this is a remnant of older approaches to coc compiler that is not useful anymore. Anyways compiling withoutBE_USE_PRECOMPILED_OBJECTwas already half broken.@skiars are you ok to drop the non-BE_USE_PRECOMPILED_OBJECT ?