Use opts.userDataDir if launchPersistentContext calls with empty args

berstend · Apr 3, 2024 · 923f9b2 · 923f9b2
1 parent 39248f1
commit 923f9b2
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/playwright-extra/src/extra.ts b/packages/playwright-extra/src/extra.ts
@@ -17,7 +17,7 @@ interface AugmentedLauncherAPIs
   extends Pick<
     PlaywrightBrowserLauncher,
     'launch' | 'launchPersistentContext' | 'connect' | 'connectOverCDP'
-  > {}
+  > { }
 
 /**
  * Modular plugin framework to teach `playwright` new tricks.
@@ -119,6 +119,14 @@ export class PlaywrightExtraClass implements AugmentedLauncherAPIs {
     options =
       (await this.plugins.dispatchBlocking('beforeLaunch', options)) || options
 
+    if ('userDataDir' in options && !userDataDir) {
+      userDataDir = (options as any).userDataDir
+      debug(
+        "A plugin defined userDataDir during .launchPersistentContext", userDataDir
+      )
+      delete (options as any).userDataDir
+    }
+
     const context = await this.launcher['launchPersistentContext'](
       userDataDir,
       options