Launch options merge fixed #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey.
No, my issue is related to launch method only, where merge is not
required at all and can be avoided.
…On 15.09.2020 22:25, Darryl Norris wrote:
Hey @zdm <https://github.com/zdm> ,
If I am not wrong this PR
<#268> solves this
issue. We are have considering moving to object-merge-advanced with
isPlainObject.
Do you know if this will fix your problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#322 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH2MSEF2Q43PTBXGFRHVJDSF65RVANCNFSM4RNAKJ3Q>.
|
|
The test Could somebody merge this PR pls? |
|
What's the benefit of this, performance? This will be gone in the rewrite (#303) anyway: https://github.com/berstend/puppeteer-extra/pull/303/files#diff-204794cd3a2e9247e20d8a1f99cc73c8R75-R91 I've pushed the responsibility of checking that I'm inclined to close this issue until there's more info provided. |
|
Closing in favor of #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deepmerge when merging options in launch() method.