IFLIGHT_BORG_F435 #614
Open
IFLIGHT_BORG_F435 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
haslinghuis
reviewed
Dec 1, 2024
|
it’s tested already and it have been pass |
ot0tot
reviewed
Jan 6, 2025
| TIMER_PIN_MAP( 3, PB1, 2, 2 ) \ | ||
| TIMER_PIN_MAP( 4, PC8, 2, 1 ) \ | ||
| TIMER_PIN_MAP( 5, PC9, 2, 3 ) \ | ||
| TIMER_PIN_MAP( 6, PB6, 1, 11 ) \ |
There was a problem hiding this comment.
DMA request conflicts with ADC1
ot0tot
reviewed
Jan 6, 2025
| #define MANUFACTURER_ID IFRC | ||
|
|
||
| // LEDS | ||
| #define LED0_PIN PC15 |
There was a problem hiding this comment.
PC15 cannot be used to drive a status LED
ot0tot
reviewed
Jan 6, 2025
| #define PINIO1_PIN PC14 | ||
|
|
||
| // TIMERS & DMA | ||
| #define TIMER_PIN_MAPPING TIMER_PIN_MAP( 0, PA8, 1, 8 ) \ |
There was a problem hiding this comment.
Motor outputs are split over 4 timers, which is not acceptable.
https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#32-resource-selection-considerations
ot0tot
reviewed
Jan 6, 2025
|
@Jason-iFlight needs some changes |
ot0tot
reviewed
Feb 17, 2025
ot0tot
reviewed
Feb 17, 2025
| #define UART6_RX_PIN PC7 | ||
| #define UART6_TX_PIN PC6 | ||
| #define USB_DETECT_PIN PC5 | ||
| #define SERIALRX_UART SERIAL_PORT_USART2 |
There was a problem hiding this comment.
UART2 is susceptible to DFU hijacking and should not be used for receivers/GPS
ot0tot
reviewed
Feb 17, 2025
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
|
@Jason-iFlight this will need retesting and PROPER testing... you would have had issues with the conflicts... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.