Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cookiecutter): adapter_type to lowercase #442

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

qleroy
Copy link
Contributor

@qleroy qleroy commented Mar 30, 2024

Summary

Fixes #441.

This makes the adapter_type in cookiecutter.json to lowercase so that it matches the adapter directory names and make the script post_gen_project.sh work.

Testing instructions

$ git clone https://github.com/betodealmeida/shillelagh.git
$ cd shillelagh
$ python -m venv venv
$ source venv/bin/activate
$ python -m pip install cookiecutter
$ cookiecutter templates/adapter/

Copy link
Owner

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@betodealmeida betodealmeida merged commit a3ceb8c into betodealmeida:main Apr 3, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookiecutter : cp: cannot create regular file 'src/shillelagh/adapters/API/': Not a directory
2 participants