fix(GSheets): invalid pattern

src/shillelagh/adapters/api/gsheets/lib.py

@@ -49,10 +49,10 @@ def get_field(
     """
     Return a Shillelagh ``Field`` from a Google Chart API results column.
     """
-    # GSheets returns type ``datetime`` for timestamps, but also for time of day and
-    # durations. We need to tokenize the pattern in order to figure out the correct type.
-    if col["type"] == "datetime" and "pattern" in col:
-        col["type"] = infer_column_type(col["pattern"])
+    # GSheets returns all kind of incorrect types (eg, ``datetime`` or ``timeofday`` for
+    # timestamps. We parse the patter in order to infer the correct type.
+    if col["type"] in {"datetime", "timeofday"} and "pattern" in col:
+        col["type"] = infer_column_type(col["pattern"].lower())
 
     type_map: Dict[str, Tuple[Type[GSheetsField], List[Type[Filter]]]] = {
         "string": (GSheetsString, [Range, Equal, NotEqual, Like, IsNull, IsNotNull]),

src/shillelagh/adapters/api/gsheets/parsing/base.py

@@ -115,6 +115,8 @@ def tokenize(pattern: str, classes: List[Type[Token]]) -> Iterator[Token]:
                 token, pattern = class_.consume(pattern, tokens)
                 tokens.append(token)
                 break
+        else:
+            raise InvalidPattern(f'Could not consume "{pattern}"')
 
     # combine unescaped literals
     while tokens:

src/shillelagh/adapters/api/gsheets/parsing/date.py

@@ -538,6 +538,9 @@ def infer_column_type(pattern: str) -> str:
 
     GSheets returns ``datetime`` as the type for timestamps, but also for time of day and
     durations. We need to parse the pattern to figure out the exact type.
+
+    This also handles a case where a timestamp (``1/2/24 14:41``) with a proper pattern
+    (``M/D/YY h:mm``) was being returned as type ``timeofday``.
     """
     classes = [
         # durations should come first because they need to be modified

tests/adapters/api/gsheets/lib_test.py

@@ -94,6 +94,21 @@ def test_get_field() -> None:
         Order.ANY,
         True,
     )
+    assert get_field(
+        {
+            "id": "A",
+            "label": "Send time",
+            "type": "timeofday",
+            "pattern": "M/D/YY h:mm",
+        },
+        timezone,
+    ) == GSheetsDateTime(
+        [Range, Equal, NotEqual, IsNull, IsNotNull],
+        Order.ANY,
+        True,
+        "M/D/YY h:mm",
+        timezone,
+    )
 
 
 def test_format_error_message() -> None:

tests/adapters/api/gsheets/parsing/base_test.py

@@ -9,6 +9,7 @@
 
 from shillelagh.adapters.api.gsheets.parsing.base import (
     LITERAL,
+    InvalidPattern,
     InvalidValue,
     is_unescaped_literal,
     tokenize,
@@ -84,6 +85,10 @@ def test_tokenize() -> None:
         LITERAL(")"),
     ]
 
+    with pytest.raises(InvalidPattern) as excinfo:
+        list(tokenize("dd/mm/yyyy", []))
+    assert str(excinfo.value) == 'Could not consume "dd/mm/yyyy"'
+
 
 def test_is_unescaped_literal() -> None:
     """