Skip to content

Conversation

@sulkaharo
Copy link

Now running this in production and it works. I changed this to report the values in mgdl, as it's way easier to handle the data if decocare just decodes to one set of units consistently. So LGTM with my patch.

@bewest
Copy link
Owner

bewest commented Jan 1, 2016

Not sure how I feel about this. Decocare is supposed to be stupid simple, like curl, it was originally a tool to tell exactly what is going on inside the device. In the past, I've been pretty disciplined/strict about separating conversions: https://github.com/openaps/openaps/blob/master/openaps/vendors/units.py, I think we're at a point where a better openaps medtronic should be created to make a lot of this easier: an oref0 version of the medtronic vendor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants