Merged
Conversation
ravening
reviewed
Aug 21, 2024
| BasicAuthenticationFilter.class) | ||
| .authorizeHttpRequests(authorize -> authorize | ||
| .requestMatchers( | ||
| antMatcher(HttpMethod.GET, "/"), |
There was a problem hiding this comment.
Do you want to whitelist swagger endpoints as well in case we add support for that?
Contributor
Author
There was a problem hiding this comment.
I think it's better to add any swagger configuration only when swagger will eventually be added, so the starter project stays as clean as possible.
ravening
reviewed
Aug 21, 2024
| return request.getHeader(AUTH_HEADER); | ||
| } | ||
| @Value("${app.name}") | ||
| private String APP_NAME; |
There was a problem hiding this comment.
this naming convention is wrong. this type of naming convention should be used only for static variables. for local variables, camel case is good enough
bfwg
requested changes
Aug 23, 2024
Owner
bfwg
left a comment
bfwg
left a comment
There was a problem hiding this comment.
hi @mirkoperillo , good stuff. The code indentation looks off to me. Can you change them back to 4 spaces per tab?
Contributor
Author
@bfwg do you have time to review this PR ? |
🐧🐳⬆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an upgrade of project from Spring Boot 2.7 to Spring Boot 3.3
Some notes:
jakarta.servlet.httppackage, so I removed it from the projectjjwtlibrary to support the newjakarta.xml.bindpackage. In the new versionjjwtAPI changed a lot so I had to rewrite part of theTokenHelperclass.