Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get country by code_phone #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

majidtaherkhani
Copy link

General

Reference: <ISSUE_ID>


Description:

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Additional notes

* @returns {Array} An array of country objects
*/
const getCountryDetailsBylanguageCodes = (language_code) => {
let resultArray = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majidtaherkhani

Suggested change
let resultArray = [];
return data.filter(item => item["language_codes"].includes(language_code))

@harshsaini786
Copy link
Contributor

nit - @majidtaherkhani try to use filter function instead of pushing result in an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants