meta: Update CI and follow linter suggestions #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfhoster1312
force-pushed
the
update-ci
branch
6 times, most recently
from
8c7f7f4 to
8986a5c
Compare
selfhoster1312
force-pushed
the
update-ci
branch
2 times, most recently
from
6b8fdbb to
f1bb981
Compare
I have no idea if that's how to handle errors in goroutines and deferred function calls. Please review properly.
selfhoster1312
force-pushed
the
update-ci
branch
from
f1bb981 to
e0c1690
Compare
Author
|
Sooooo i spent a few hours playing robot with my keyboard and monkeytyping stuff to get the CI working. I'm disabled a few imho useless lints, and there's just 2 left that don't pass and i think are important and require some level of review:
Otherwise on this branch golangci-lint should run without simply comparing errors with the previous commit which is a terrible way to accumulate tech debt and let it fall on the first person submitting a PR. Feel free to review. In particular, this commit deserves special attention: d47a7dc Because i have no idea what i'm doing in there i'm merely working around the linter errors and i don't know what's the idiomatic way to handle defer/goroutine errors in golang. |
selfhoster1312
changed the title
This was referenced Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed CI was failing on #20 but i could not reproduce because the version of
golangci-lintis so old… so i updated to latest github actions release, and tested with the latest golangci-lint release.I had to remove some linters i have no idea what they do but they don't exist anymore. Some migration stuff was documented here but not everything because we were so old (our config wasn't even versioned so the migrate subcommand failed to validate).
Anyway i'm not sure it'll pass yet so let's pray to the CI gods :)