Skip to content

Retrieve context, comments and reference via translate directive#102

Open
felixpis wants to merge 1 commit into
biesbjerg:masterfrom
felixpis:context-comments
Open

Retrieve context, comments and reference via translate directive#102
felixpis wants to merge 1 commit into
biesbjerg:masterfrom
felixpis:context-comments

Conversation

@felixpis

Copy link
Copy Markdown

Now in html we can write
<span translate translate-context="VERB" translate-comment="This is a title one">Title</span>
And then in generated .pot file:
# This is a title one
#: example/example.html
msgctxt "VERB"
msgid "Title"
msgstr ""

#37

@picheli20

Copy link
Copy Markdown

Why this is not merged yet?? 😢

@picheli20

Copy link
Copy Markdown

@felixpis just a suggestion, I've added the pipe and function as well for the extraction (later I've noticed that the pipe will need some work), if you want to include this base :) picheli20@a3e1987

@bagage

bagage commented Nov 30, 2018

Copy link
Copy Markdown

Nice @picheli20, however there are some failing tests now (npm run test). Would be great to have this merged! @biesbjerg are you still open to new MR?

@bagage

bagage commented Nov 30, 2018

Copy link
Copy Markdown

Also when the same string is used multiple times, only one path is registered in the .pot file. Shouldn't all files be listed?

@bram-atmire

bram-atmire commented Dec 9, 2018

Copy link
Copy Markdown

@picheli20 Apologies if this is an inappropriate place to ask, but would be great if you could clarify the following.

Let's say that I use the pipe:
{{ 'Home' | translate }}

How can I pass along/express context and comments there?

@felixpis made it clear how it works in the HTML tags, e.g.

<span translate translate-context="Context for home" translate-comment="Comment for home">Home</span>

@Eugeny

Eugeny commented Jan 25, 2019

Copy link
Copy Markdown

@felixpis do you think you could release this separately on NPM? It doesn't look like it's going to get merged anytime soon

@jovpet

jovpet commented Jun 14, 2019

Copy link
Copy Markdown

still no merge, please do something! @felixpis, I've noticed that all the comments are being removed upon .po update. For instance my config is ngx-translate-extract --input ./src --output ./src/assets/i18n/*.po --c --f pot and when I have clean .po files (fr.po and en.po) comments are there, Once I run extract, and I need to make un update, all the comments get cleared.

@shavenzov

Copy link
Copy Markdown

You can use forked version with added context and comment support. This version adds file path to the item in .po file also.

https://www.npmjs.com/package/@shavenzov/ngx-translate-extract

@philoliver

Copy link
Copy Markdown

Hello, any reason why this is not merged yet? Any workarounds available?

P4 pushed a commit to P4/ngx-translate-extract that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants