Skip to content

Chore(deps): Bump actions/download-artifact from 3 to 6 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.14.3-bc
Choose a base branch
from
Open

Chore(deps): Bump actions/download-artifact from 3 to 6 #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ jobs:
- uses: actions/checkout@v2

- name: Download ${{ matrix.arch }} zip
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
Copy link

@sentry sentry bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: download-artifact@v6 is incompatible with upload-artifact@v2 and v3.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The download-artifact@v6 action attempts to retrieve artifacts uploaded using actions/upload-artifact@v2 in build.yml and actions/upload-artifact@v3 in nightly-test-*.yaml workflows. These versions are incompatible due to architectural changes introduced in actions/download-artifact@v4 and later. This mismatch will cause artifact download steps to fail, preventing subsequent workflow stages like binary verification and UI testing from completing.

💡 Suggested Fix

Update actions/upload-artifact to v4 or later in all workflows (build.yml, nightly-test-*.yaml) where actions/download-artifact@v6 is used to ensure compatibility.

🤖 Prompt for AI Agent 
Fix this bug. In .github/workflows/build.yml at line 329: The `download-artifact@v6`
action attempts to retrieve artifacts uploaded using `actions/upload-artifact@v2` in
`build.yml` and `actions/upload-artifact@v3` in `nightly-test-*.yaml` workflows. These
versions are incompatible due to architectural changes introduced in
`actions/download-artifact@v4` and later. This mismatch will cause artifact download
steps to fail, preventing subsequent workflow stages like binary verification and UI
testing from completing.

Did we get this right? 👍 / 👎 to inform future reviews.

with:
name: ${{ env.zip_name }}

Expand Down Expand Up @@ -356,7 +356,7 @@ jobs:
- uses: actions/checkout@v2

- name: Download amd64 darwin zip
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: ${{ env.zip_name }}

Expand Down Expand Up @@ -391,7 +391,7 @@ jobs:
echo "pkg_name=consul_${{ env.pkg_version }}-1_${{ matrix.arch }}.deb" >> $GITHUB_ENV

- name: Download workflow artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: ${{ env.pkg_name }}

Expand Down Expand Up @@ -428,7 +428,7 @@ jobs:
echo "pkg_name=consul-${{ env.pkg_version }}-1.${{ matrix.arch }}.rpm" >> $GITHUB_ENV

- name: Download workflow artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: ${{ env.pkg_name }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-test-1.11.x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
run: make deps

- name: Download OSS Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-oss-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-test-1.12.x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
run: make deps

- name: Download OSS Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-oss-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-test-1.13.x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
run: make deps

- name: Download OSS Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-oss-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-test-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
run: make deps

- name: Download OSS Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-oss-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
run: make deps

- name: Download ENT Frontend
uses: actions/download-artifact@v3
uses: actions/download-artifact@v6
with:
name: frontend-ent-${{ env.BRANCH_NAME }}
path: ./ui/packages/consul-ui/dist
Expand Down
Loading