Allow to keep un-namespaced attributes AND attributes with "cas" prefix #50
Open
nox-404 wants to merge 2 commits intobiola:masterfrom
Open
Allow to keep un-namespaced attributes AND attributes with "cas" prefix #50nox-404 wants to merge 2 commits intobiola:masterfrom
nox-404 wants to merge 2 commits intobiola:masterfrom
Conversation
Author
|
This allow rack-cas to work with CAS like the one from web2py |
Collaborator
|
Thanks for putting the work in on this @nox-404. I wasn't aware that web2py used CAS authentication so that's good to know. There are enough different CAS implementations that I'm thinking I need to stop trying to have the code figure out which one is which automatically, and instead have different "plugins" for each different type of extra attributes format. So I'm thinking I'll hold off on merging this in favor of that approach. I'll leave this open until I have a solution in place though. If it takes me a while then I'll come back and merge this in. |
Author
|
Ok thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will keep all attributes into extra_attributes["cas"]