fix!: remove configFile configuration key
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE
This PR removes the
configFileoption from thebiome.projectssetting.Description
When specified, the
configFileoption would start the LSP server with the additional--config-pathoption which instructs Biome to load the configuration file from a custom path.When I initially started working on the v3 pre-release, I was working under the incorrect assumption that starting Biome with
--lsp-proxycreated an entirely independent process when, in fact, it would still start a Biome daemon.While passing
--config-pathto Biome when first starting, it wasn't an issue; we discovered that when starting Biome multiple times (across various projects), only the configuration file referenced by the project that first started Biome would be considered.Providing an option to use a custom config file is still valuable, but we'll remove this option from the pre-release while looking for an alternative solution.
Impact
While this is a breaking change, which we try to avoid, this is still a pre-release, and most of the documentation isn't officially published, so the impact will likely be minimal.