fix: migrate modal gestures and avoid render-time shared value reads#185
Open
PrajTS wants to merge 1 commit intobirdwingo:mainfrom
Open
fix: migrate modal gestures and avoid render-time shared value reads#185PrajTS wants to merge 1 commit intobirdwingo:mainfrom
PrajTS wants to merge 1 commit intobirdwingo:mainfrom
Conversation
Move modal gestures to GestureDetector with GestureHandlerRootView so stories work reliably on Android modals. Remove render-time shared value reads that trigger Reanimated warnings across story components. Update Jest gesture mocks and interaction tests so the new gesture flow is covered by the existing test suite. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAnimatedGestureHandler/PanGestureHandlertoGesture.Pan()withGestureDetectorGestureHandlerRootViewso gesture handling works correctly when rendered inside a React NativeModalon AndroidWhy
The current modal gesture implementation relies on the older gesture handler API and can break when rendered inside Android modals. The package also reads Reanimated shared values during React render in several places, which triggers warnings on newer Reanimated versions.
Verification
npm run buildnpm test -- --runInBandMade with Cursor