Introduce Coin Selection page #448
Conversation
The coins list model will be used to list out of the locked and selectable coins in the coin selection form. A toggle method is provided that will select or unselect the coin in the associated WalletQmlModel.
The CoinSelection page is opened up from the Send page. The button to push CoinSelection on the Send page stack is enabled in the ellipsis menu. The toggle in the ellipsis menu can set a QSetting for enabled/disabled. All of these components are added to the DesktopWallets and Send page.
|
Oh great to see this page being built! Suggestion (I did not test build): the Total Selected and Over required amount list items should be sticky/Freezed and should always be on the top. This will help the user track these numbers while they're scrolling and selecting coins. Otherwise they have to scroll to the top to check... |
Yeah I agree on this. I'll move that component outside of the scroll view. |
Interesting, ill try to reproduce and fix this.
I'll add the scroll bar to the list
All amount inputs and labels aren't going to look great right now. I need to create the components to display these values properly as well as the state to hold the preferences but i will be getting there soon. |
|
Updates were made to address all comments outside of the issues with the amounts and the amount resetting after send. These are related issues and will be addressed when I circle back around to solve the BitcoinAmount formatting feature. |
There was a problem hiding this comment.
12aa84c
some other things I noticed while testing (maybe as notes for follow-up)
- the over or remaining to select is not displaying the right value in case the review button doesn't work (this happens sometimes, was mentioned in previous PR)
Screencast.from.2025-03-31.16-55-52.webm
- the coinlist shouldn't be open-enable in case the user has no coins?
- sometimes when a re-index is needed it displays a random number (which I have not been able to repro using qt)
| text: if (root.wallet.coinsListModel.overRequiredAmount) { | ||
| qsTr("Over required amount") | ||
| } else { | ||
| qsTr("Remaining to select") |
There was a problem hiding this comment.
nit, if exact amount is selected is it good UX to have Remaining to select 0.000000?
| @@ -0,0 +1,48 @@ | |||
| // Copyright (c) 2024 The Bitcoin Core developers | |||
There was a problem hiding this comment.
nit; some are 2025, same added files are 2024 or 2023
This PR depends on #445
This is the first iteration of the Coin Selection menu
The option to open the Coin Selection menu is a QSetting that is toggled on/off in the ellipsis menu on the Send page. When enabled, the user can click on the Select inputs button and the Coin Selection menu will be push on the stack from below. The Coin Selection menu will list possible inputs and a checkbox is used to select the coins. Locked coins
are not selectable and instead of a check box, they have a locked icon.
Screencast.from.2025-03-25.00-49-26.mp4