cmake: Add option to recreate precomputed files #1791
+40
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
force-pushed
the
251220-cmake-precomputed
branch
2 times, most recently
from
cbc6679 to
5373c6a
Compare
Contributor
|
are we able to do this via or is this meant to be only done for CMake? |
Member
Author
Yes. Run |
hebasto
force-pushed
the
251220-cmake-precomputed
branch
from
5373c6a to
f9eeb11
Compare
Member
Author
|
Thank you for the review! Your feedback has been addressed. |
hebasto
force-pushed
the
251220-cmake-precomputed
branch
from
f9eeb11 to
fdfda7b
Compare
real-or-random
added a commit
that referenced
this pull request
Jan 27, 2026
47eb709 ecmult: Use size_t for array indices in _odd_multiplies_table (Tim Ruffing) bb1d199 ecmult: Use size_t for array indices into tables (Tim Ruffing) Pull request description: I don't think the current code is incorrect, but using `size_t` improves readability because the type makes it clear that we're dealing with array indices. Also, making the result of the `ECMULT_TABLE_SIZE` macro (hopefully) a `size_t` fixes a compiler warning on MSVC, see #1791. ACKs for top commit: hebasto: re-ACK 47eb709. jonasnick: ACK 47eb709 theStack: ACK 47eb709 Tree-SHA512: e484fd610d50e972021c0184a683993364290eb58e09b65f9521b4507ec8d0639b402c67002005630b389bc863a7aa05b75f7224524dbcbafbfa5f9a4812b4a5
hebasto
force-pushed
the
251220-cmake-precomputed
branch
from
fdfda7b to
8b58c55
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the CMake-based build system enables smoother integration with parent projects by providing both CMake package configuration files and the traditional
libsecp256k1.pc.However, packagers on some systems, such as Gentoo and Guix, insist on recreating the precomputed files, which is not currently supported by the CMake-based build system.
This PR addresses the issue by introducing a new build option,
SECP256K1_BUILD_PRECOMPUTED, which is disabled by default.