Conversation
sipa
reviewed
Jan 26, 2026
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 27, 2026
14e56970cb Merge bitcoin-core/secp256k1#1794: ecmult: Use size_t for array indices c7a52400d6 Merge bitcoin-core/secp256k1#1809: release cleanup: bump version after 0.7.1 ae7eb729c0 release cleanup: bump version after 0.7.1 1a53f4961f Merge bitcoin-core/secp256k1#1808: Prepare for 0.7.1 20a209f11c release: prepare for 0.7.1 c4b6a81a60 changelog: update in preparation for the v0.7.1 release ebb35882da Merge bitcoin-core/secp256k1#1796: bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS c09215f7af bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS 471e3a130d Merge bitcoin-core/secp256k1#1800: sage: verify Eisenstein integer connection for GLV constants 29ac4d8491 sage: verify Eisenstein integer connection for GLV constants 4721e077b4 Merge bitcoin-core/secp256k1#1793: doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult bd5ced1fe1 doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult 47eb70959a ecmult: Use size_t for array indices in _odd_multiplies_table bb1d199de5 ecmult: Use size_t for array indices into tables 2d9137ce9d Merge bitcoin-core/secp256k1#1764: group: Avoid using infinity field directly in other modules f9a944ff2d Merge bitcoin-core/secp256k1#1790: doc: include arg -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON for cmake 0406cfc4d1 doc: include arg -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1 for cmake 8d445730ec Merge bitcoin-core/secp256k1#1783: Add VERIFY_CHECKs and documentation that flags must be 0 or 1 aa2a39c1a7 Merge bitcoin-core/secp256k1#1778: doc/bench: Added cmake build options to bench error messages 540fec8ae9 Merge bitcoin-core/secp256k1#1788: test: split monolithic ellswift test into independent cases d822b29021 test: split monolithic ellswift test into independent cases ae00c552df Add VERIFY_CHECKs that flags are 0 or 1 5c75183344 Merge bitcoin-core/secp256k1#1784: refactor: remove ret from secp256k1_ec_pubkey_serialize be5e4f02fd Merge bitcoin-core/secp256k1#1779: Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL 3daab83a60 refactor: remove ret from secp256k1_ec_pubkey_serialize 8bcda186d2 test: Add non-NULL checks for "pointer of array" API functions 5a08c1bcdc Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL 3b5b03f301 doc/bench: Added cmake build options to bench error messages e7f7083b53 Merge bitcoin-core/secp256k1#1774: refactor: split up internal pubkey serialization function into compressed/uncompressed variants b6c2a3cd77 Merge bitcoin-core/secp256k1#1761: ecmult_multi: reduce strauss memory usage by 30% f5e815f430 remove secp256k1_eckey_pubkey_serialize function 0d3659c547 use new `_eckey_pubkey_serialize{33,65}` functions in modules (ellswift,musig) adb76f82ea use new `_eckey_pubkey_serialize{33,65}` functions in public API fc7458ca3e introduce `secp256k1_eckey_pubkey_serialize{33,65}` functions c8206b1ce6 Merge bitcoin-core/secp256k1#1771: ci: Use Python virtual environment in "x86_64-macos-native" job f252da7e6e ci: Use Python virtual environment in "x86_64-macos-native" job 115b135fe8 Merge bitcoin-core/secp256k1#1763: bench: Use `ALIGNMENT` macro instead of hardcoded value 2f73e5281d group: Avoid using infinity field directly in other modules 153eea20c2 bench: Use `ALIGNMENT` macro instead of hardcoded value 26166c4f5f ecmult_multi: reduce strauss memory usage by 30% 7a2fff85e8 Merge bitcoin-core/secp256k1#1758: ci: Drop workaround for Valgrind older than 3.20.0 43e7b115f7 Merge bitcoin-core/secp256k1#1759: ci: Switch to macOS 15 Sequoia Intel-based image 8bc50b72ff ci: Switch to macOS 15 Sequoia Intel-based image c09519f0e3 ci: Drop workaround for Valgrind older than 3.20.0 git-subtree-dir: src/secp256k1 git-subtree-split: 14e56970cba37ffe4ee992c1e08707a16e22e345
hebasto
reviewed
Jan 27, 2026
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
Post -merge ACK 20a209f.
I've verified potential ABI changes since v0.7.0:
I still stand by my previous suggestion.
fjahr
added a commit
to fjahr/bitcoin
that referenced
this pull request
Jan 29, 2026
15ea24cb8c batch: make add functions void & introduce reset bfcc479a35 batch: remove `batch_usable` api 15e388e096 batch: make tests functions internal & static aac054a373 fix typos & index the right inputs for benchmarks c07e710003 batch: remove experimental status 49fb753393 test: fix ci failures e96dabb4af batch: Generate speedup graphs b0b3425cd4 batch, extrakeys: Add benchmarks 9d5115156b batch: Add tests for batch_add_* APIs 668199c917 batch,ecmult: Add tests for core batch APIs and strauss_batch refactor 53a158203f batch: Add example b40b4186b8 batch: Add batch_add_* APIs 2bed1cb6ee batch, ecmult: Add batch_verify and refactor strauss_batch 8f13eeae31 batch: Add create and destroy APIs 0b6b0c87ad batch: Initialize an experimental batch module REVERT: 14e56970cb Merge bitcoin-core/secp256k1#1794: ecmult: Use size_t for array indices REVERT: c7a52400d6 Merge bitcoin-core/secp256k1#1809: release cleanup: bump version after 0.7.1 REVERT: ae7eb729c0 release cleanup: bump version after 0.7.1 REVERT: 1a53f4961f Merge bitcoin-core/secp256k1#1808: Prepare for 0.7.1 REVERT: 20a209f11c release: prepare for 0.7.1 REVERT: c4b6a81a60 changelog: update in preparation for the v0.7.1 release REVERT: ebb35882da Merge bitcoin-core/secp256k1#1796: bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS REVERT: c09215f7af bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS REVERT: 471e3a130d Merge bitcoin-core/secp256k1#1800: sage: verify Eisenstein integer connection for GLV constants REVERT: 29ac4d8491 sage: verify Eisenstein integer connection for GLV constants REVERT: 4721e077b4 Merge bitcoin-core/secp256k1#1793: doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult REVERT: bd5ced1fe1 doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult REVERT: 47eb70959a ecmult: Use size_t for array indices in _odd_multiplies_table REVERT: bb1d199de5 ecmult: Use size_t for array indices into tables REVERT: 2d9137ce9d Merge bitcoin-core/secp256k1#1764: group: Avoid using infinity field directly in other modules REVERT: f9a944ff2d Merge bitcoin-core/secp256k1#1790: doc: include arg -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON for cmake REVERT: 0406cfc4d1 doc: include arg -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1 for cmake REVERT: 8d445730ec Merge bitcoin-core/secp256k1#1783: Add VERIFY_CHECKs and documentation that flags must be 0 or 1 REVERT: aa2a39c1a7 Merge bitcoin-core/secp256k1#1778: doc/bench: Added cmake build options to bench error messages REVERT: 540fec8ae9 Merge bitcoin-core/secp256k1#1788: test: split monolithic ellswift test into independent cases REVERT: d822b29021 test: split monolithic ellswift test into independent cases REVERT: ae00c552df Add VERIFY_CHECKs that flags are 0 or 1 REVERT: 5c75183344 Merge bitcoin-core/secp256k1#1784: refactor: remove ret from secp256k1_ec_pubkey_serialize REVERT: be5e4f02fd Merge bitcoin-core/secp256k1#1779: Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL REVERT: 3daab83a60 refactor: remove ret from secp256k1_ec_pubkey_serialize REVERT: 8bcda186d2 test: Add non-NULL checks for "pointer of array" API functions REVERT: 5a08c1bcdc Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL REVERT: 3b5b03f301 doc/bench: Added cmake build options to bench error messages REVERT: e7f7083b53 Merge bitcoin-core/secp256k1#1774: refactor: split up internal pubkey serialization function into compressed/uncompressed variants REVERT: b6c2a3cd77 Merge bitcoin-core/secp256k1#1761: ecmult_multi: reduce strauss memory usage by 30% REVERT: f5e815f430 remove secp256k1_eckey_pubkey_serialize function REVERT: 0d3659c547 use new `_eckey_pubkey_serialize{33,65}` functions in modules (ellswift,musig) REVERT: adb76f82ea use new `_eckey_pubkey_serialize{33,65}` functions in public API REVERT: fc7458ca3e introduce `secp256k1_eckey_pubkey_serialize{33,65}` functions REVERT: 2f73e5281d group: Avoid using infinity field directly in other modules REVERT: 26166c4f5f ecmult_multi: reduce strauss memory usage by 30% git-subtree-dir: src/secp256k1 git-subtree-split: 15ea24cb8c1bd239a7a39939da1952cf6d3a35b0
fjahr
added a commit
to fjahr/bitcoin
that referenced
this pull request
Jan 31, 2026
15ea24cb8c batch: make add functions void & introduce reset bfcc479a35 batch: remove `batch_usable` api 15e388e096 batch: make tests functions internal & static aac054a373 fix typos & index the right inputs for benchmarks c07e710003 batch: remove experimental status 49fb753393 test: fix ci failures e96dabb4af batch: Generate speedup graphs b0b3425cd4 batch, extrakeys: Add benchmarks 9d5115156b batch: Add tests for batch_add_* APIs 668199c917 batch,ecmult: Add tests for core batch APIs and strauss_batch refactor 53a158203f batch: Add example b40b4186b8 batch: Add batch_add_* APIs 2bed1cb6ee batch, ecmult: Add batch_verify and refactor strauss_batch 8f13eeae31 batch: Add create and destroy APIs 0b6b0c87ad batch: Initialize an experimental batch module REVERT: 14e56970cb Merge bitcoin-core/secp256k1#1794: ecmult: Use size_t for array indices REVERT: c7a52400d6 Merge bitcoin-core/secp256k1#1809: release cleanup: bump version after 0.7.1 REVERT: ae7eb729c0 release cleanup: bump version after 0.7.1 REVERT: 1a53f4961f Merge bitcoin-core/secp256k1#1808: Prepare for 0.7.1 REVERT: 20a209f11c release: prepare for 0.7.1 REVERT: c4b6a81a60 changelog: update in preparation for the v0.7.1 release REVERT: ebb35882da Merge bitcoin-core/secp256k1#1796: bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS REVERT: c09215f7af bench: fail early if user inputs invalid value for SECP256K1_BENCH_ITERS REVERT: 471e3a130d Merge bitcoin-core/secp256k1#1800: sage: verify Eisenstein integer connection for GLV constants REVERT: 29ac4d8491 sage: verify Eisenstein integer connection for GLV constants REVERT: 4721e077b4 Merge bitcoin-core/secp256k1#1793: doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult REVERT: bd5ced1fe1 doc/bench: added help text for SECP256K1_BENCH_ITERS env var for bench_ecmult REVERT: 47eb70959a ecmult: Use size_t for array indices in _odd_multiplies_table REVERT: bb1d199de5 ecmult: Use size_t for array indices into tables REVERT: 2d9137ce9d Merge bitcoin-core/secp256k1#1764: group: Avoid using infinity field directly in other modules REVERT: f9a944ff2d Merge bitcoin-core/secp256k1#1790: doc: include arg -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON for cmake REVERT: 0406cfc4d1 doc: include arg -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1 for cmake REVERT: 8d445730ec Merge bitcoin-core/secp256k1#1783: Add VERIFY_CHECKs and documentation that flags must be 0 or 1 REVERT: aa2a39c1a7 Merge bitcoin-core/secp256k1#1778: doc/bench: Added cmake build options to bench error messages REVERT: 540fec8ae9 Merge bitcoin-core/secp256k1#1788: test: split monolithic ellswift test into independent cases REVERT: d822b29021 test: split monolithic ellswift test into independent cases REVERT: ae00c552df Add VERIFY_CHECKs that flags are 0 or 1 REVERT: 5c75183344 Merge bitcoin-core/secp256k1#1784: refactor: remove ret from secp256k1_ec_pubkey_serialize REVERT: be5e4f02fd Merge bitcoin-core/secp256k1#1779: Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL REVERT: 3daab83a60 refactor: remove ret from secp256k1_ec_pubkey_serialize REVERT: 8bcda186d2 test: Add non-NULL checks for "pointer of array" API functions REVERT: 5a08c1bcdc Add ARG_CHECKs to ensure "array of pointers" elements are non-NULL REVERT: 3b5b03f301 doc/bench: Added cmake build options to bench error messages REVERT: e7f7083b53 Merge bitcoin-core/secp256k1#1774: refactor: split up internal pubkey serialization function into compressed/uncompressed variants REVERT: b6c2a3cd77 Merge bitcoin-core/secp256k1#1761: ecmult_multi: reduce strauss memory usage by 30% REVERT: f5e815f430 remove secp256k1_eckey_pubkey_serialize function REVERT: 0d3659c547 use new `_eckey_pubkey_serialize{33,65}` functions in modules (ellswift,musig) REVERT: adb76f82ea use new `_eckey_pubkey_serialize{33,65}` functions in public API REVERT: fc7458ca3e introduce `secp256k1_eckey_pubkey_serialize{33,65}` functions REVERT: 2f73e5281d group: Avoid using infinity field directly in other modules REVERT: 26166c4f5f ecmult_multi: reduce strauss memory usage by 30% git-subtree-dir: src/secp256k1 git-subtree-split: 15ea24cb8c1bd239a7a39939da1952cf6d3a35b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.