Add license notice to API headers - #1927
Open
theStack wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #412 in a pragmatic way, adding the same MIT license block we use in internal files (see e.g. in the most recent modules ellswift, musig and silentpayments) for the public headers. Depending on how nit-picky we are one could further refine this, e.g.:
Copyright (c) 2013-present The libsecp256k1 developers, with different starting years depending on when a module was developed/merged, or even without any year)?/* SPDX-License-Identifier: MIT */) for machine readability?Probably it's not worth it to spend a lot of time on this; I guess one way to "solve" this is also to simplify leave as-is (and then still close #412 referring to that decision), but it seems at least quite common that public headers in C libraries contain some minimum copyright/licensing information.