Skip to content

fix(portability): avoid printing non-POSIX line number on error exits #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 6, 2025
Merged

fix(portability): avoid printing non-POSIX line number on error exits #2459

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b6ad17
split up the ERR and EXIT traps
bitcoin-tools Oct 3, 2025
cfe92f0
Update nodebuilder
bitcoin-tools Oct 3, 2025
926dc3e
fix conditional syntax
bitcoin-tools Oct 3, 2025
a18de8c
fix: remove line number from output
bitcoin-tools Oct 3, 2025
88ab41d
Update nodebuilder
bitcoin-tools Oct 3, 2025
c2a1142
Update nodebuilder
bitcoin-tools Oct 3, 2025
b37cb39
Merge branch 'master' into 2401-bug---unhandled-error-at-line-1
bitcoin-tools Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodebuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,7 +1630,7 @@ done

[ "${unit_tests}" = 'true' ] && run_unit_tests

trap 'if [ $? -eq 0 ]; then handle_exit; else throw_error "Unhandled error at line ${LINENO:-}."; fi' EXIT
trap 'if [ $? -eq 0 ]; then handle_exit; else throw_error "Unhandled error during nodebuilder execution."; fi' EXIT
trap handle_sigint INT

readonly BYTES_TO_KIB=1024
Expand Down