Bump bitcoin dependency to ^0.29, minor related fixes #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
bump_bitcoin_029
branch
2 times, most recently
from
e67e470 to
cf8a159
Compare
notmandatory
force-pushed
the
bump_bitcoin_029
branch
from
cf8a159 to
bd7f9c1
Compare
|
I would wait for #83 and #84 to be merged first. I'm planning to make one more release that's still on 0.28 because we can't update bdk yet, but i would still like to have the new features and fixes for the next bdk release. Once that release is done we can merge this and make another release, which we will hopefully use in bdk next month once miniscript is also updated for 0.29 |
|
You can go ahead and rebase now :) |
notmandatory
force-pushed
the
bump_bitcoin_029
branch
from
bd7f9c1 to
d132572
Compare
afilini
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version bump for
bitcoindependency is required to fix bitcoindevkit/bdk#646.