add confidence score for geoIp #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcisiozf
reviewed
Sep 1, 2025
workers/loc.api/net.util.js
Outdated
| const accuracyRadius = geo.area | ||
|
|
||
| // Define a max expected radius beyond which confidence is zero | ||
| const maxExpectedRadius = 500 // kilometers |
tarcisiozf
previously approved these changes
Sep 8, 2025
tarcisiozf
approved these changes
Sep 10, 2025
jalbertsr
approved these changes
Sep 11, 2025
vigan-abd
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geoIpbased on theaccuracy_radius.accuracy_radiuslesser the confidence, shorter theaccuracy_radiusbetter theconfidenceScoreTicket