Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/difference with matches uniq #41

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dictor93
Copy link
Contributor

@dictor93 dictor93 commented Mar 3, 2025

Description:

Added new features differenceWith, matches, uniq
Updated deepClone to make it correctly work with buffers, regex, Map, Set and other complex objects

New features:

  • differenceWith
  • matches
  • uniq

Updated:

  • deepClone

PR status:

  • Version bumped
  • Change-log updated
  • Tests added or updated
  • PR keeps 100% test coverage
  • Type definition updated
  • Readme updated
  • Linter is applied
  • Const arrow functions are used instead of pure function definitions where applicable
  • Functions are listed in alphabetic order in index.js, index.d.ts and readme

@dictor93 dictor93 force-pushed the feat/differenceWith-matches-uniq branch from 11f8638 to ea790ca Compare March 3, 2025 21:20
grantfayvor
grantfayvor previously approved these changes Apr 1, 2025
Copy link

@grantfayvor grantfayvor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

@batrudinych batrudinych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls resolve conflict

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@bitfinexcom/lib-js-util-base",
"version": "1.19.1",
"version": "1.20.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update package-lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants