Make DavException and HttpException immutable; provide status code for HttpException #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exception always has a status code
rfc2822
force-pushed
the
93-httpexceptionstatuscode-may-be-null
branch
from
35f3fe7 to
5d708cc
Compare
rfc2822
force-pushed
the
93-httpexceptionstatuscode-may-be-null
branch
from
5d708cc to
b6648bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rfc2822
changed the title
rfc2822
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DavException and HttpException classes to make them immutable and ensures HttpException always has a status code. The refactoring extracts HTTP response information processing into a separate HttpResponseInfo class to improve separation of concerns and testability.
Key changes:
- Made exception data immutable by converting mutable properties to constructor parameters
- Extracted HTTP response processing logic into
HttpResponseInfoclass with comprehensive test coverage - Ensured
HttpExceptionalways has a non-null status code through constructor design
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/at/bitfire/dav4jvm/exception/DavException.kt | Refactored to use immutable properties and delegate HTTP processing to HttpResponseInfo |
| src/main/kotlin/at/bitfire/dav4jvm/exception/HttpException.kt | Made immutable with guaranteed status code and added convenience properties for status classification |
| src/main/kotlin/at/bitfire/dav4jvm/exception/HttpResponseInfo.kt | New class extracting HTTP response processing logic with proper text/XML detection |
| src/test/kotlin/at/bitfire/dav4jvm/exception/DavExceptionTest.kt | Simplified tests to focus on constructor behavior and serialization |
| src/test/kotlin/at/bitfire/dav4jvm/exception/HttpExceptionTest.kt | New comprehensive tests for HttpException functionality |
| src/test/kotlin/at/bitfire/dav4jvm/exception/HttpResponseInfoTest.kt | New comprehensive tests for HttpResponseInfo extraction logic |
| src/test/kotlin/at/bitfire/dav4jvm/exception/ServiceUnavailableExceptionTest.kt | Minor formatting improvements to request builder |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
DavExceptionandHttpExceptionissues mentioned in #93:HttpExceptionis guaranteed to have a status code. The status codes 3xx, 4xx and 5xx can now explicitly be detected byisRedirectetc., as this is often used by DAVx⁵.Extracting the HTTP information (status code request/response excerpt) has been moved to a separate class which is also tested separately.