Skip to content

Conversation

@ArnyminerZ
Copy link
Member

Purpose

See #1737, but basically, Push is basically stable enough to at least select a distributor by default.

In any case, if one doesn't trust it, the server admin should simply not install support for push on the server, and the distributor will be unused.

Short description

  • Added automatic push distributor selection
    • Added a new injectable class called DistributorPreferences. It contains a list of package names which will define what the preference for each distributor is.
    • For OSE, no distributor has preference.
    • For Play Store builds we might want to pre-select FCM for example, or for managed. This can be set with the DistributorPreferences implementation.
  • Added a new settings entry which will be set to true whenever the user manually disables push (because it will be enabled by default). If this setting is true, no push distributor will be automatically selected.

We still have to add the individual implementations for each flavor on bitfireAt/davx5.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ ArnyminerZ self-assigned this Oct 25, 2025
@ArnyminerZ ArnyminerZ requested a review from a team as a code owner October 25, 2025 10:58
@ArnyminerZ ArnyminerZ added enhancement New feature or request push related to WebDAV-Push labels Oct 25, 2025
@ArnyminerZ ArnyminerZ linked an issue Oct 25, 2025 that may be closed by this pull request
@sunkup sunkup force-pushed the 1737-enable-push-by-default branch from adfee4b to 09f359d Compare November 20, 2025 10:58
@sunkup
Copy link
Member

sunkup commented Nov 20, 2025

I will change to draft for now and we can reopen when we want to merge it - that is when we know in which version it will be added.

@sunkup sunkup marked this pull request as draft November 20, 2025 11:18
@rfc2822 rfc2822 force-pushed the 1737-enable-push-by-default branch from d4c00a0 to 6e0cde7 Compare December 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request push related to WebDAV-Push

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Push by default

2 participants