-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LumexUI to the list (#18) #20
base: develop
Are you sure you want to change the base?
Conversation
Button is not shown properly because Tailwind is not included and styles are not generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should follow the installation guide here: https://lumexui.org/docs/getting-started/installation
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="9.0.2" /> | ||
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="9.0.2" PrivateAssets="all" /> | ||
</ItemGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this in the project file to download the Tailwind CLI without npm and generate CSS
<Target Name="InstallTailwind" AfterTargets="PostBuildEvent" Condition="!Exists('tailwindcss.exe')">
<Exec Command="curl -LO https://github.com/tailwindlabs/tailwindcss/releases/download/v3.4.17/tailwindcss-windows-x64.exe" />
<Exec Command="ren tailwindcss-windows-x64.exe tailwindcss.exe" />
</Target>
<Target Name="RunTailwind" AfterTargets="InstallTailwind">
<Exec Command="tailwindcss -i ./wwwroot/globals.css -o ./wwwroot/app.min.css --minify" />
</Target>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be the hardest one among all BlazorUI libraries I've tested so far from 2019.
I'll keep this as draft, feel free to clone it and make it work and submit it to me (":
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I can imagine it! No problem, I will just keep updating LumexUI to support Tailwind CSS v4. This change will significantly improve the installation process.
Hey, @ysmoradi I checked #22 and noticed that I didn't have *.wasm requests in the Network tab. Turns out, you were right. Then, I checked www.mudblazor.com and found that their package is 1.1MB. Seemed a bit strange at first, but then I remembered that someone had asked me about trimming in LumexUI. That’s the reason why LumexUI is 1.4MB in the docs. I will fix that as soon as possible. It should get waaaaay smaller afterwards. Thanks for bringing this to my attention! |
Yes! making libraries trimmable is the thing that we absolutely need in dotnet frontend community! |
closes #18