Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish #22

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Spanish #22

wants to merge 19 commits into from

Conversation

zzaappedd
Copy link

I know it has to have many mistakes. Got to learn to check for quotes and ; semicolon line endings with my text editor. Hopefully is not too bad.


/* No comment provided by engineer. */
/* suspicious error repeated? signing transaction*/
"Sign Trasaction" = "Firmando transacción";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out this misspelling. This is our fault. You may delete this line now. @zzaappedd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suspicious error repeated? signing transaction

@songchenwen
Copy link
Contributor

👍 Thank you for your PR.

I'll try to compile and run your changes.

As I can see by now, the project config file should also be edited. Don't worry I will edit this, and submit it with the merge.

One more thing to mention, we usually work on the develop branch. And we want the master branch to always represents our online production state. So after reviewed, this PR will be manually merged into our develop branch. Since Github only takes commits on master as contributions, you will be listed as Bither's contributors when we release the next version (develop will be merged into master).

@songchenwen
Copy link
Contributor

songchenwen commented Jun 3, 2015

I've found some trivial issues.

  1. bither-ios WatchKit App/es.lproj/interface.srings's file name is misspelled.
  2. Some lines in bither-ios/es.lproj/Localizable.strings are not well formatted and prevent compiling.
  3. Some option names are too long to display on my iPhone5s.
  4. The project.pbxproj needs to be edited to include the Spanish translation.

I have already solved the 1 2 and 4 issues. I will submit these changes in a new pull request to your repo. But since I don't know Spanish at all, I can not solve the 3 issue.

There are only 2 steps left for you before we merging your PR.

  • Go to your own repo and merge my newly created PR.
  • Check my screenshots under my PR to see which lines are too long. And try to reduce the length.

When adding new commits to your repo on the patch-1 branch, this PR will be updated automatically. No extra effort is needed.

Copy link

@Kalliingi Kalliingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants