Add DecoderConfig to Player #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android: - Remove unnecessary `resolveOnUiThread` call - Remove unnecessary `DecoderConfigBridge` - Add `decoderConfigModule` extension val to `ReactApplicationContext` and `RejectPromiseOnExceptionBlock` - Add additional parameter to `PlayerModule` `init` functions (add `decoderNativeId`, similar to `networkNativeId`) - Add extension function `ReadableArray.toMediaCodecInfo` to parse the decoder priority result from rn RN - Fix `DecoderContextMediaType` enum values - `DecoderConfig` extends `NativeInstanceConfig` now - Refactor and fix `decoder/index.ts` - add `export` statement to export the decoderConfig - Add missing `destroy` to the decoderConfig on player destroy
src/player.ts
Outdated
Comment on lines
525
to
527
| console.warn( | ||
| `[Player ${this.nativeId}] config: PlaybackConfig.DecoderConfig is not available for iOS. Only Android devices.` | ||
| ); |
There was a problem hiding this comment.
This should not be called on iOS as this results in a visible warning in the application!
I think keeping just the return should be enough.
Otherwise you need the same check on the caller side of initDecoderConfig
testcenter
force-pushed
the
PA-2888/decoder-config
branch
from
e8d56eb to
c3529bf
Compare
testcenter
force-pushed
the
PA-2888/decoder-config
branch
from
c3529bf to
c38b514
Compare
testcenter
force-pushed
the
PA-2888/decoder-config
branch
from
c38b514 to
e2a2f68
Compare
testcenter
requested review from
zigavehovec,
strangesource and
rolandkakonyi
and removed request for
a team
zigavehovec
requested changes
Mar 26, 2025
There was a problem hiding this comment.
Would be nice to have a minimal PR description.
I performed some basic tests and it's looking good on Android. I'm having some issues building on iOS, but still looking into it.
Please feel free to ping me if you need any help working through the comments I added 🙂
| @@ -105,6 +105,6 @@ dependencies { | |||
| // Bitmovin | |||
| implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.35.1' | |||
| implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1' | |||
| implementation 'com.bitmovin.player:player:3.104.2+jason' | |||
| implementation 'com.bitmovin.player:player-media-session:3.104.2+jason' | |||
| implementation 'com.bitmovin.player:player:3.106.0-a.1-decoderconfig+jason' | |||
There was a problem hiding this comment.
Just a reminder comment to update this when the final release is out 🙂
android/src/main/java/com/bitmovin/player/reactnative/DecoderConfigModule.kt
Show resolved
Hide resolved
android/src/main/java/com/bitmovin/player/reactnative/DecoderConfigModule.kt
Show resolved
Hide resolved
- Update comments - Fix formatting - Make fields private Co-authored-by: Žiga Vehovec <[email protected]>
strangesource
approved these changes
Mar 27, 2025
zigavehovec
reviewed
Mar 28, 2025
There was a problem hiding this comment.
Please make sure to take a look at #622 (comment)
After that we are ready to go IMO 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the player-android
3.106release we will introduce a newDecoderConfigto thePlaybackConfig.With this PR we introduce the
DecoderConfigAPI on react-native.In addition, the
3.106release will remove some Tweaks. The affected tweak will also be removed in this react-native project in favor of theDecoderConfig(Removed tweak:preferSoftwareDecodingForAds)Changes
DecoderConfigModuledecoderConfig(+ usage inPlaybackConfigTweaksConfig.preferSoftwareDecodingForAdsChecklist
CHANGELOGentry