Skip to content

change hostname settings #36340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −6
Open

change hostname settings #36340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc77b90
change hostname settings
Oct 10, 2025
7e2d1b4
Update CHANGELOG.md
bitnami-bot Oct 15, 2025
e692a6f
Update CHANGELOG.md
bitnami-bot Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions bitnami/keycloak/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
# Changelog

## 25.2.5 (2025-10-09)
## 25.2.6 (2025-10-16)

* [bitnami/keycloak] Fix: Rename duplicated secret labels ([#36254](https://github.com/bitnami/charts/pull/36254))
* change hostname settings ([#36340](https://github.com/bitnami/charts/pull/36340))

## <small>25.2.4 (2025-09-23)</small>
## <small>25.2.5 (2025-10-08)</small>

* [bitnami/keycloak] Fix indentation in ingress TLS secret template ([#36282](https://github.com/bitnami/charts/pull/36282))
* [bitnami/keycloak] Fix: Rename duplicated secret labels (#36254) ([9b3915b](https://github.com/bitnami/charts/commit/9b3915b649a9b08fbfad1fa82cc24e48232edd36)), closes [#36254](https://github.com/bitnami/charts/issues/36254)

## <small>25.2.4 (2025-10-02)</small>

* [bitnami/keycloak] Fix indentation in ingress TLS secret template (#36282) ([3f7fa45](https://github.com/bitnami/charts/commit/3f7fa45393366ca67af940efa64acfab89c05e75)), closes [#36282](https://github.com/bitnami/charts/issues/36282)

## <small>25.2.3 (2025-09-11)</small>

Expand Down
2 changes: 1 addition & 1 deletion bitnami/keycloak/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ maintainers:
name: keycloak
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/keycloak
version: 25.2.5
version: 25.2.6
2 changes: 1 addition & 1 deletion bitnami/keycloak/templates/configmap-env-vars.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ data:
{{- end }}
{{- if .Values.ingress.enabled }}
KC_HOSTNAME_STRICT: {{ ternary "true" "false" .Values.hostnameStrict | quote }}
{{- if .Values.ingress.hostname }}
{{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }}
Copy link
Contributor

@jotamartos jotamartos Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the "eq true" condition is a bit redundant. Can you review this change?

Suggested change
{{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }}
{{- if and .Values.ingress.hostname .Values.hostnameStrict }}

{{- $path := tpl .Values.ingress.path . }}
{{- if and (eq .Values.ingress.controller "gce") (hasSuffix "*" $path) }}
{{- $path = trimSuffix "*" $path }}
Expand Down
Loading