Skip to content

Conversation

@TomHellier
Copy link
Contributor

@TomHellier TomHellier commented Oct 20, 2025

Description of the change

The sharded storegateway should have as similar behaviour to the non-sharded store gateway.

Follows the same pattern as the non-sharded store gateway here.

Benefits

Easier configuration of extraFlags

Possible drawbacks

If users set relabel-configs as part of the extraFlags, then it will overwrite the relabel-configs written by the sharded storegateway. But, I'd imagine anyone who is doing that would understand how to resolve that if they're opting into the non standard sharded configuration

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…he template for non-sharded statefulset storegateway

Signed-off-by: Tom Hellier <[email protected]>
@github-actions github-actions bot added thanos triage Triage is needed labels Oct 20, 2025
@github-actions github-actions bot requested a review from carrodher October 20, 2025 15:52
Signed-off-by: Bitnami Bot <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 21, 2025
Signed-off-by: Bitnami Bot <[email protected]>
@github-actions github-actions bot removed the triage Triage is needed label Oct 21, 2025
@github-actions github-actions bot removed the request for review from carrodher October 21, 2025 09:15
@github-actions github-actions bot requested a review from alvneiayu October 21, 2025 09:15
@alvneiayu alvneiayu merged commit 2dfd26c into bitnami:main Nov 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solved thanos verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thanos helm chart failing to tpl extraFlags for sharded storegateway statefulsets

4 participants