bitnami/thanos template extraFlags in sharded statefulset storegateway like the template for non-sharded statefulset storegateway #36360
+9
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The sharded storegateway should have as similar behaviour to the non-sharded store gateway.
Follows the same pattern as the non-sharded store gateway here.
Benefits
Easier configuration of extraFlags
Possible drawbacks
If users set relabel-configs as part of the extraFlags, then it will overwrite the relabel-configs written by the sharded storegateway. But, I'd imagine anyone who is doing that would understand how to resolve that if they're opting into the non standard sharded configuration
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm