[bitnami/argo-cd] Use http port of service in ingress when insecure flag is set on server

[maxnitze]

Description of the change

Which port of the ArgoCD server service is used by the ingress is defined by whether or not the server provides an https endpoint and not based on the TLS configuration of the ingress.

Benefits

Bugfix: Some tools and services try to gather the scheme used to communicate with the server from the name and/or port number it communicates with.

Traefik is an example: If you tell Traefik to communicate with a service with name https and/or on port 443 (through the service config of your Ingress resource), it will try to connect to it with https. If your server does not "speak" https, then you'll end up with a "502 Bad Gateway".

There could also be other things with similar problems, like health checks and such.

Even for tools/ingress controllers, that are doing http by default, using a service named https, that actually does plain http makes it harder to understand and has no benefit, in my opinion.

Possible drawbacks

None

Applicable issues

None

Additional information

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)