Step run func #873
Merged
Step run func #873
+173
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
previously approved these changes
Jun 22, 2023
tothszabi
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a NO version update
Context
The goal of this PR is to leave less room for engineers to accidentally break the secret redaction on the step run logs.
One change is discarding the usage of (and removing)
tools.EnvmanRun, as the rest of its features are only used when running a step, but at the same time thetools.EnvmanRunseemed to be a generic function, which is open for many configurations.Another change is testing if the root writer of the
stepoutput.Writeris a secret redactor when secrets are provided.Resolves: https://bitrise.atlassian.net/browse/CI-1102
Changes
WorkflowRunner.executeStepactivateStepLibStepfrom run_utils.go to step_activator.go (as it is used only from this file)stepoutput.Writeris a secret redactor when secrets are provided