Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step run func 2 #874

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Step run func 2 #874

merged 4 commits into from
Jun 23, 2023

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Jun 21, 2023

Checklist

Version

Requires a NO version update

Context

This PR introduces a new package stepruncmd, which encapsulates all the aspects of a step execution.

Resolves: https://bitrise.atlassian.net/browse/CI-1102

Changes

  • Introduce stepruncmd package
  • Add unit tests for secret redaction

Base automatically changed from step-run-func to master June 22, 2023 13:57
@@ -0,0 +1,66 @@
package stepruncmd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stepoutputwriter.go content moved here. The only change is that the constructor's parameter is an io.Writer and not an opts log.LoggerOpts

@godrei godrei marked this pull request as ready for review June 22, 2023 14:34
@godrei godrei merged commit d2d4706 into master Jun 23, 2023
2 checks passed
@godrei godrei deleted the step-run-func-2 branch June 23, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants