[PM-40519] feat: Add passkey cipher storage and identity foundation to TestHarness - #2977
Open
morganzellers-bw wants to merge 1 commit into
Open
[PM-40519] feat: Add passkey cipher storage and identity foundation to TestHarness#2977morganzellers-bw wants to merge 1 commit into
morganzellers-bw wants to merge 1 commit into
Conversation
morganzellers-bw
added
app:password-manager
Contributor
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
- Coverage 79.53% 79.51% -0.02%
==========================================
Files 1169 1169
Lines 75095 75095
==========================================
- Hits 59724 59715 -9
- Misses 15371 15380 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
morganzellers-bw
force-pushed
the
pm-40519-testharness-passkeys-storage-foundation
branch
3 times, most recently
from
August 20, 2026 16:47
e3f6aa9 to
4d77e40
Compare
morganzellers-bw
force-pushed
the
pm-40519-testharness-passkeys-storage-foundation
branch
2 times, most recently
from
August 26, 2026 19:08
c91e387 to
51be49b
Compare
fedemkr
reviewed
Aug 26, 2026
Member
There was a problem hiding this comment.
🎨 I think we should think about moving our current CipherView fixtures from BitwardenSdk+VaultFixtures in BitwardenShared to BitwardenKit so it can be shared amongst all apps.
Same applies to Fido2CredentialAutofillView and Fido2CredentialView.
Perhaps moving the whole file there. What do you think @bitwarden/team-ios @matt-livefront ?
Contributor
Author
There was a problem hiding this comment.
I like that idea
Comment on lines
+6
to
+10
| // sourcery: AutoMockable | ||
| /// A service that locally persists the SDK-encrypted `Cipher`s created by the SDK-backed passkey | ||
| /// scenarios, so they survive app relaunches. | ||
| /// | ||
| protocol CipherStorageService: AnyObject { |
Member
There was a problem hiding this comment.
⛏️ We usually put sourcery inline with the protocol definition. I'm almost certain that you should get a warning on how it's done there above the DocC.
Suggested change
| // sourcery: AutoMockable | |
| /// A service that locally persists the SDK-encrypted `Cipher`s created by the SDK-backed passkey | |
| /// scenarios, so they survive app relaunches. | |
| /// | |
| protocol CipherStorageService: AnyObject { | |
| /// A service that locally persists the SDK-encrypted `Cipher`s created by the SDK-backed passkey | |
| /// scenarios, so they survive app relaunches. | |
| /// | |
| protocol CipherStorageService: AnyObject { // sourcery: AutoMockable |
Comment on lines
+34
to
+35
| /// The `UserDefaults` key under which the persisted ciphers are stored. | ||
| private static let storageKey = "PasskeyStoredCiphers" |
Member
There was a problem hiding this comment.
🤔 I wonder if we should use some key format alike what we use now in AppSettingsStore, i.e. bwPreferencesStorage:{key}. So in here it'd would be something like thPreferencesStorage:{key}.
Comment on lines
+52
to
+64
| func loadCiphers() -> [Cipher] { | ||
| guard let data = userDefaults.data(forKey: Self.storageKey), | ||
| let storedCiphers = try? JSONDecoder().decode([StoredCipher].self, from: data) else { | ||
| return [] | ||
| } | ||
| return storedCiphers.map(\.cipher) | ||
| } | ||
|
|
||
| func save(ciphers: [Cipher]) { | ||
| let storedCiphers = ciphers.compactMap(StoredCipher.init(cipher:)) | ||
| guard let data = try? JSONEncoder().encode(storedCiphers) else { return } | ||
| userDefaults.set(data, forKey: Self.storageKey) | ||
| } |
Member
There was a problem hiding this comment.
🤔 I usually like to avoid try? as we wouldn't have any errors logged if one would happen. Could you add some logging here or rethrow the error in case it happens? At least on the OSLog.
Member
There was a problem hiding this comment.
⛏️ Update string keys to follow standards.
Introduces the persistence and data-model layer for the SDK-backed passkey scenarios: a UserDefaults-backed cipher store, its Codable mirror of the SDK's Cipher/Fido2Credential shape, the synthetic identity model, keychain item, and supporting errors/fixtures. This is the foundation the Fido2-driving services (registration, assertion, credential listing) build on top of in a follow-up PR.
morganzellers-bw
force-pushed
the
pm-40519-testharness-passkeys-storage-foundation
branch
from
August 27, 2026 16:38
51be49b to
f4b8cb4
Compare
Contributor
Author
🤖 Claude Security Code Review 🤖PR: (#2945) - PM-40519 feat: Add SDK-backed passkey registration and assertion services to TestHarness — 2026-08-27 Date: 2026-08-27 Commits reviewed: c419835..c4f80a6 · 2 commits · TestHarnessShared/Core/Autofill/Passkey/
Summary
📝 NotesExpand for details on (14) notes
✅ StrengthsExpand for details on (13) strengths
❌ DismissedExpand for details on (5) dismissed findings
Net result: 0 Blockers, 0 Improvements — nothing here should hold up the PR. The 14 Notes are all low-cost hardening opportunities around the synthetic identity's error handling, keychain namespacing, and defensive serialization; worth a follow-up cleanup pass but not urgent given the complete isolation from production trust boundaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-40519
📔 Objective
Adds the persistence and data-model foundation for passkey test scenarios in the TestHarness, split from PR #2945 for size.
CipherStorageServicepersists SDK-encrypted ciphers across app relaunches, backed byUserDefaults.StoredCipheris aCodablemirror of the handful ofCipher/Fido2Credentialfields these scenarios populate, sinceBitwardenSdk.Cipherisn't itselfCodable.SyntheticIdentity/PasskeyKeychainItemmodel the throwaway identity persisted in the Keychain so the same crypto keys survive relaunches.PasskeyErrorand supporting fixtures round out the layer.Fido2CredentialStore/Fido2UserInterface/PasskeyServicelayer on top of this.testHarness_passkeys_flow.MP4
Stack: #2977 → #2945 → #2946 → #2947 → #2948