Skip to content

Commit

Permalink
[BRE-101] Remove dept-devops from CODEOWNERS (#826)
Browse files Browse the repository at this point in the history
## 🎟️ Tracking

<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

https://bitwarden.atlassian.net/browse/BRE-101

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->

Remove dept-devops from CODEOWNERS and add `bitwarden/dept-bre` for all
release workflows.

## 📸 Screenshots

<!-- Required for any UI changes; delete if not applicable. Use fixed
width images for better display. -->

## ⏰ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## 🦮 Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or
concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or
indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes

---------

Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Vince Grassia <[email protected]>
  • Loading branch information
3 people authored Oct 17, 2024
1 parent 8aea2e9 commit 37b22fe
Showing 1 changed file with 42 additions and 2 deletions.
44 changes: 42 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,43 @@
#
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# BRE for publish workflow changes
.github/workflows/publish-*.yml @bitwarden/dept-bre

# Shared workflows ownership

## BRE & SM teams shared ownership
.github/workflows/build-cli-docker.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-cli.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-bws.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-python.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev

## Multiple owners
.github/workflows/build-android.yml
.github/workflows/build-rust-crates.yml
.github/workflows/build-rust-cross-platform.yml
.github/workflows/build-swift.yml
.github/workflows/build-wasm-internal.yml
.github/workflows/build-wasm.yml
.github/workflows/release-rust-crates.yml
.github/workflows/release-swift.yml
.github/workflows/release-wasm.yml
.github/workflows/version-bump.yml


# DevOps for Actions and other workflow changes.
.github/workflows @bitwarden/dept-devops

# Secrets Manager team
crates/bitwarden-sm @bitwarden/team-secrets-manager-dev
Expand All @@ -16,3 +50,9 @@ crates/bws @bitwarden/team-secrets-manager-dev
crates/bws/Cargo.toml
crates/bws/scripts/install.ps1
crates/bws/scripts/install.sh

## Docker files have shared ownership ##
**/Dockerfile
**/*.Dockerfile
**/.dockerignore
**/entrypoint.sh

0 comments on commit 37b22fe

Please sign in to comment.