[PM-12400] Add private key regeneration SDK methods #1133
Closed
+246
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remaining: UUID
I really shouldn't need to be fixing this
…tion' into km/pm-12400/private-key-regen
|
No New Or Fixed Issues Found |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
+ Coverage 58.17% 58.54% +0.37%
==========================================
Files 197 197
Lines 13587 13745 +158
==========================================
+ Hits 7904 8047 +143
- Misses 5683 5698 +15 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
PM-11764-implement-account-switching-and-sdk-initialization
to
main
October 14, 2024 12:44
quexten
approved these changes
Oct 22, 2024
|
@Thomas-Avery This will need to be moved to https://github.com/bitwarden/sdk-internal. It should be as simple as changing remote and pushing the branch. All the history is preserved in the new repo. |
|
Closing, opened on sdk-internal here bitwarden/sdk-internal#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12400
📔 Objective
Add shared methods to enable private key regeneration in clients.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes