Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-367 - Update regex in Publish Java workflow #1143

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Oct 16, 2024

🎟️ Tracking

📔 Objective

This PR updates the regex in the Publish Java workflow to match semver instead of calver. I also updated the build.gralde file to remove the rc branch references.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 16, 2024
@vgrassia vgrassia requested a review from a team as a code owner October 16, 2024 19:26
@vgrassia vgrassia enabled auto-merge (squash) October 16, 2024 19:27
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Logo
Checkmarx One – Scan Summary & Details51808d2d-53ed-4e72-8274-7708a0c01987

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.17%. Comparing base (c22c216) to head (0f2a6e0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.02%     
==========================================
  Files         197      197              
  Lines       13584    13587       +3     
==========================================
  Hits         7904     7904              
- Misses       5680     5683       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia closed this Oct 17, 2024
@vgrassia vgrassia reopened this Oct 17, 2024
@vgrassia vgrassia requested a review from a team as a code owner October 17, 2024 14:25
@vgrassia vgrassia removed the request for review from a team October 17, 2024 14:25
@vgrassia vgrassia enabled auto-merge (squash) October 17, 2024 14:26
@vgrassia vgrassia merged commit 6babf9e into main Oct 17, 2024
191 of 193 checks passed
@vgrassia vgrassia deleted the bre-367_fix-publish-java-sdk-workflow branch October 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants