Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12989] Create process for qa to build client with particular sdk version #1145

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 17, 2024

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsbc5c8d63-3fc2-4073-a7e9-0b9075059e2b

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.13%. Comparing base (c5a7419) to head (d9f4fad).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/client.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   58.15%   58.13%   -0.02%     
==========================================
  Files         197      197              
  Lines       13587    13590       +3     
==========================================
  Hits         7901     7901              
- Misses       5686     5689       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu force-pushed the PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version branch from 41da834 to 401d008 Compare October 21, 2024 09:48
@coroiu coroiu force-pushed the PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version branch from 401d008 to d9f4fad Compare October 21, 2024 12:58
@coroiu
Copy link
Contributor Author

coroiu commented Oct 22, 2024

Closing and moving to bitwarden/sdk-internal#5

@coroiu coroiu closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant