Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-367 - Update logic to use version only #1146

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the build.gradle script to use the version number. The way our Publish Java SDK workflow works is that it never checks out main, which made the Gradle script always use -SNAPSHOT in the URL which is not valid.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 17, 2024
@vgrassia vgrassia requested a review from a team October 17, 2024 15:13
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6783d1db-8bf2-415c-baa0-7d348f13a1d5

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.17%. Comparing base (6babf9e) to head (9c8c56f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   58.17%   58.17%           
=======================================
  Files         197      197           
  Lines       13587    13587           
=======================================
  Hits         7904     7904           
  Misses       5683     5683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia merged commit 6460db2 into main Oct 17, 2024
98 of 99 checks passed
@vgrassia vgrassia deleted the bre-367_fix-gradle-script branch October 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants