-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13377] Remove moved libraries #1151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Issues
|
# Conflicts: # .github/workflows/build-android.yml # .github/workflows/build-swift.yml # .github/workflows/build-wasm-internal.yml # .github/workflows/delete-old-packages.yml # .github/workflows/memory-testing.yml # .github/workflows/publish-internal.yml # .github/workflows/release-swift.yml # crates/bitwarden-exporters/resources/json_export.json # crates/bitwarden-exporters/src/json.rs # crates/bitwarden-exporters/src/lib.rs # crates/bitwarden-exporters/src/models.rs # crates/bitwarden-vault/src/cipher/attachment.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/cipher/mod.rs # crates/bitwarden-vault/src/mobile/client_ciphers.rs # crates/bitwarden-vault/src/totp.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
===========================================
- Coverage 58.60% 10.17% -48.44%
===========================================
Files 198 19 -179
Lines 13782 1101 -12681
===========================================
- Hits 8077 112 -7965
+ Misses 5705 989 -4716 ☔ View full report in Codecov by Sentry. |
dani-garcia
approved these changes
Oct 21, 2024
Thomas-Avery
approved these changes
Oct 21, 2024
vgrassia
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13377
📔 Objective
PR for removing duplicates crates caused by the split from unified SDK to SM specific SDK.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes