Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13377] Remove moved libraries #1151

Merged
merged 3 commits into from
Oct 21, 2024
Merged

[PM-13377] Remove moved libraries #1151

merged 3 commits into from
Oct 21, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 21, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13377

📔 Objective

PR for removing duplicates crates caused by the split from unified SDK to SM specific SDK.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners October 21, 2024 16:11
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Logo
Checkmarx One – Scan Summary & Details58c0fc02-0eea-4570-9a1c-e6b5c247e881

Fixed Issues

Severity Issue Source File / Package
MEDIUM Parameter_Tampering /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 384
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 73
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 136
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 67
LOW Healthcheck Instruction Missing /Dockerfile: 38
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 67
LOW Unpinned Actions Full Length Commit SHA /release-swift.yml: 73
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
LOW Unpinned Actions Full Length Commit SHA /release-swift.yml: 136
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 61

@Hinton Hinton changed the title Remove moved libraries [PM-13377] Remove moved libraries Oct 21, 2024
# Conflicts:
#	.github/workflows/build-android.yml
#	.github/workflows/build-swift.yml
#	.github/workflows/build-wasm-internal.yml
#	.github/workflows/delete-old-packages.yml
#	.github/workflows/memory-testing.yml
#	.github/workflows/publish-internal.yml
#	.github/workflows/release-swift.yml
#	crates/bitwarden-exporters/resources/json_export.json
#	crates/bitwarden-exporters/src/json.rs
#	crates/bitwarden-exporters/src/lib.rs
#	crates/bitwarden-exporters/src/models.rs
#	crates/bitwarden-vault/src/cipher/attachment.rs
#	crates/bitwarden-vault/src/cipher/cipher.rs
#	crates/bitwarden-vault/src/cipher/mod.rs
#	crates/bitwarden-vault/src/mobile/client_ciphers.rs
#	crates/bitwarden-vault/src/totp.rs
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.17%. Comparing base (38ecf13) to head (406c2c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1151       +/-   ##
===========================================
- Coverage   58.60%   10.17%   -48.44%     
===========================================
  Files         198       19      -179     
  Lines       13782     1101    -12681     
===========================================
- Hits         8077      112     -7965     
+ Misses       5705      989     -4716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit f7cba45 into main Oct 21, 2024
80 of 81 checks passed
@Hinton Hinton deleted the ps/remove-internal branch October 21, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants