Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1236] - Update release go workflow #787

Merged
merged 16 commits into from
May 21, 2024

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented May 15, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update the Go Release workflow so that it inserts the static lib files into the changes that will get pushed to the bitwarden/sm-sdk-go repo on releases.

A successful workflow (dry)-run can be found here.

Code changes

  • .github/workflows/release-go.yml:
    • update artifacts to reflect supported targets (x86_64 Linux, macOS, and Windows + aarch64 Linux and macOS)
    • rename the Go module to match the repo we are pushing to, removing the need for the in-line find-and-replacement of the Go module name
  • rename the Go module
  • remove the unused uuid import in the Go wrapper. it is only used in the example.go project, where it is already imported.

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link
Contributor

github-actions bot commented May 15, 2024

Logo
Checkmarx One – Scan Summary & Detailsf989ce0c-501a-4b91-bb52-73a89d1f68e4

No New Or Fixed Issues Found

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.55%. Comparing base (0e3553a) to head (ec6e773).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files         178      178           
  Lines       11544    11544           
=======================================
  Hits         6760     6760           
  Misses       4784     4784           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangowithfoxtrot tangowithfoxtrot changed the title Sm 1236 update release go workflow [SM-1236] - Update release go workflow May 15, 2024
@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review May 20, 2024 20:30
@tangowithfoxtrot tangowithfoxtrot requested a review from a team as a code owner May 20, 2024 20:30
@tangowithfoxtrot tangowithfoxtrot requested review from Hinton, dani-garcia and a team May 20, 2024 20:31
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangowithfoxtrot tangowithfoxtrot merged commit 656cf5d into main May 21, 2024
106 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the sm-1236-update-release-go-workflow branch May 21, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants